Merge pull request #27683 (add test for ACME)
This is a rebased version of the pull request with small fixes due to changes in recent master. Original description from the pull request: Currently this is only a very basic test which gets certificates via the enableACME option of the nginx module. However the main reason why I'm not directly merging and putting this up for review is that the complexity here lies in the support-modules needed for the test. The support modules are for running a Boulder instance along with a DNS resolver (as a separate module). For details about the implementation, see the commit messages and the comments at the start of the respective support modules. I'm merging this first of all because other than @abbradar, none of the other requested reviewers did comment on the changes and second because the change here is adding a test, so even if the implementation would be so disgusting and crappy it's better than having no test at all. The comment of @abbradar was: Can't we factor Boulder into a proper package and a NixOS service? Maybe not very general purpose for now but still -- putting everything into one test seems painful to me. My objection to this is that the components are heavily patched and some of them don't even have a release, so I'm not sure whether infesting pkgs/ with them is really a good idea. Nevertheless, we can still do that later. Cc: @fpletz, @domenkozar, @bjornfor
Please register or sign in to comment